Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(GridForm): properly align gridform infotips #2912

Merged
merged 6 commits into from
Jul 24, 2024
Merged

fix(GridForm): properly align gridform infotips #2912

merged 6 commits into from
Jul 24, 2024

Conversation

dreamwasp
Copy link
Contributor

@dreamwasp dreamwasp commented Jul 24, 2024 •
edited
Loading

Overview

Fixes misaligned Infotips - this happened because the screenreader text was a sibling to the Tip container, it is now a child of the Tip container

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: [ABC-123]
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

  • Go to GridForm story
  • See the InfoTips properly aligned
  • Turn on VO
  • Hear them properly announced
  • Double check the InfoTip story for floating and regular InfoTip, include cmd + opt text nav

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env
Portal Portal Link Portal Env

@dreamwasp dreamwasp marked this pull request as ready for review July 24, 2024 15:28
@dreamwasp dreamwasp requested a review from a team as a code owner July 24, 2024 15:28
@dreamwasp dreamwasp requested a review from villdev July 24, 2024 16:17
aresnik11
aresnik11 approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@aresnik11 aresnik11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

villdev
villdev approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@villdev villdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

LinKCoding
LinKCoding reviewed Jul 24, 2024
View reviewed changes
Copy link
Contributor

@LinKCoding LinKCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

curious why {text} was changed to be included into but works well!

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://66a1362d27d684049062f715--gamut-preview.netlify.app

Deploy Logs

@dreamwasp dreamwasp added the Ship It :shipit: Automerge this PR when possible label Jul 24, 2024
@codecademydev codecademydev merged commit ec08fd8 into main Jul 24, 2024
17 of 18 checks passed
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Jul 24, 2024
@codecademydev codecademydev deleted the cass-gf-info branch July 24, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinKCoding LinKCoding LinKCoding left review comments

@aresnik11 aresnik11 aresnik11 approved these changes

@villdev villdev villdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dreamwasp @codecademydev @aresnik11 @LinKCoding @villdev