Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(EditableIcon): Add ProgrammingTeamChatIcon #2920

Merged
merged 1 commit into from
Aug 7, 2024
Merged

feat(EditableIcon): Add ProgrammingTeamChatIcon #2920

merged 1 commit into from
Aug 7, 2024

Conversation

katiezutter
Copy link
Contributor

@katiezutter katiezutter commented Aug 5, 2024 •
edited
Loading

Overview

Adds ProgrammingTeamChatIcon.

Screenshot 2024-08-06 at 8 50 20 AM

PR Checklist

Testing Instructions

Check out the icon in the storybook preview, and in the portal-app environment using the instructions in the mono PR.

PR Links and Envs

Repository PR Link PR Env
Portal Portal Link Portal Env

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://66b14ed8bef9a922daae48ec--gamut-preview.netlify.app

Deploy Logs

@katiezutter katiezutter requested review from a team, JahazielGuzman and natalieweesh and removed request for a team August 5, 2024 22:29
@katiezutter katiezutter marked this pull request as ready for review August 6, 2024 15:52
@katiezutter katiezutter requested a review from a team as a code owner August 6, 2024 15:52
LinKCoding
LinKCoding approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@LinKCoding LinKCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@katiezutter katiezutter added the Ship It :shipit: Automerge this PR when possible label Aug 7, 2024
@codecademydev codecademydev merged commit 1d80c91 into main Aug 7, 2024
34 of 36 checks passed
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Aug 7, 2024
@codecademydev codecademydev deleted the kz-add-programming-team-chat-icon branch August 7, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinKCoding LinKCoding LinKCoding approved these changes

@JahazielGuzman JahazielGuzman Awaiting requested review from JahazielGuzman JahazielGuzman was automatically assigned from Codecademy/outcomes

@natalieweesh natalieweesh Awaiting requested review from natalieweesh natalieweesh was automatically assigned from Codecademy/outcomes

@BandanaKM BandanaKM Awaiting requested review from BandanaKM BandanaKM is a code owner automatically assigned from Codecademy/gamut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@katiezutter @codecademydev @LinKCoding