Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FloatingTip): fixes delay timeouts for hover + mouseover #2943

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(FloatingTip): fixes delay timeouts for hover + mouseover #2943

wants to merge 1 commit into from
+17 −8

Conversation

dreamwasp
Copy link
Contributor

@dreamwasp dreamwasp commented Oct 3, 2024 •
edited
Loading

Overview

Fixes FloatingTips weirdness - basically cancels the open call for Tooltips if the user doesn't hover or focus for the delay timeout

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: GM-901
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

  • head to the Floating header of the ToolTip story (link)
  • SUPER QUICKLY mouse over Tooltip
  • You should not see the ToolTip open
  • SUPER QUICKLY tab/tab away from the button
  • You should not see the ToolTip open
  • ToolTip should otherwise work the same as now

PR Links and Envs

Repository PR Link PR Env
Monorepo Monolith PR Monolith Env

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://66fed2f6f914aaf1d572ebf7--gamut-preview.netlify.app

Deploy Logs

@dreamwasp dreamwasp changed the title test cleared timeouts fix(FloatingTip): fixes delay timeouts for hover + mouseover Oct 3, 2024
@dreamwasp dreamwasp marked this pull request as ready for review October 3, 2024 21:14
@dreamwasp dreamwasp requested a review from a team as a code owner October 3, 2024 21:14
jakemhiller
jakemhiller approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@jakemhiller jakemhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakemhiller jakemhiller jakemhiller approved these changes

@timjenkins timjenkins Awaiting requested review from timjenkins timjenkins is a code owner automatically assigned from Codecademy/gamut

@aresnik11 aresnik11 Awaiting requested review from aresnik11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dreamwasp @codecademydev @jakemhiller