[MAYBE_NOT_MERGE] add RunNumber as a possible parametric sequence #7809
+113
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DIRACGridBot
added
the
alsoTargeting:integration
fstagni
force-pushed
the
fix_80_runNumber
branch
from
c808ea0
to
737181e
Compare
fstagni
force-pushed
the
fix_80_runNumber
branch
from
737181e
to
ff6d18b
Compare
atsareg
reviewed
Sep 30, 2024
| @@ -211,8 +211,19 @@ def __prepareTasksBulk(self, transBody, taskDict, owner, ownerGroup, ownerDN): | |||
| self._logError("Invalid mixture of jobs with and without input data") | |||
| return S_ERROR(ETSDATA, "Invalid mixture of jobs with and without input data") | |||
|
|
|||
| # Handle Run Number | |||
There was a problem hiding this comment.
Why do you need to treat runNumber in this way ?
atsareg
reviewed
Sep 30, 2024
| @@ -244,7 +255,7 @@ def __prepareTasksBulk(self, transBody, taskDict, owner, ownerGroup, ownerDN): | |||
| paramSeqDict.setdefault(pName, []).append(seq) | |||
|
|
|||
| for paramName, paramSeq in paramSeqDict.items(): | |||
| if paramName in ["JOB_ID", "PRODUCTION_ID", "InputData"] + outputParameterList: | |||
| if paramName in ["JOB_ID", "PRODUCTION_ID", "InputData", "runNumber"] + outputParameterList: | |||
There was a problem hiding this comment.
I think you need just this line to be modified in the WorkflowTasks.py. And shouldn't it be RunNumber to avoid any confusion with runNumber (as in the tests) ?
|
OK, I got what I needed from this one. Now, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.