Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(permissions): add SET_VOICE_CHANNEL_STATUS permission #1101

Closed
wants to merge 19 commits into from
Closed

feat(permissions): add SET_VOICE_CHANNEL_STATUS permission #1101

wants to merge 19 commits into from

Conversation

MCausc78
Copy link

@MCausc78 MCausc78 commented Sep 3, 2023

Summary

discord/discord-api-docs#6398

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added t: enhancement New feature t: api support Support of Discord API features s: needs review Issue/PR is awaiting reviews s: waiting for api/docs Issue/PR is waiting for API support/documentation s: blocked Issue/PR is blocked by other issues labels Sep 3, 2023
Copy link
Member

@EQUENOS EQUENOS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Contributor

@spifory spifory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this pull request just add one of the permissions, either set_voice_channel_status or use_clyde_ai, just to avoid scope creep

@EQUENOS
Copy link
Member

EQUENOS commented Sep 20, 2023

Could this pull request just add one of the permissions, either set_voice_channel_status or use_clyde_ai, just to avoid scope creep

Both set_voice_channel_status and use_clyde_ai are permission flags, I don't mind them being in one PR

UPD: I've just noticed that the name of the PR only mentions set_voice_channel_status, ig the title should be fixed

@shiftinv
Copy link
Member

This was split from #1090 since there are two separate api docs PRs, which won't necessarily be merged at the same time (if they ever get merged :>). For now, this is fine, but if only one of them eventually gets merged, this PR will have to be cleanly separated from the other one.

@MCausc78 MCausc78 closed this by deleting the head repository Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s: blocked Issue/PR is blocked by other issues s: needs review Issue/PR is awaiting reviews s: waiting for api/docs Issue/PR is waiting for API support/documentation t: api support Support of Discord API features t: enhancement New feature
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

4 participants