Add PHPDoc typing

Dolibarr · Aug 23, 2024 · ee5424b · ee5424b
1 parent e402b31
commit ee5424b
Showing 1 changed file with 14 additions and 2 deletions.
diff --git a/htdocs/core/actions_massactions.inc.php b/htdocs/core/actions_massactions.inc.php
@@ -36,6 +36,15 @@
 // $toselect may be defined
 // $diroutputmassaction may be defined
 
+'
+@phan-var-force ?string $permissiontoread
+@phan-var-force ?string $permissiontodelete
+@phan-var-force ?string $permissiontoclose
+@phan-var-force ?string $permissiontoread
+@phan-var-force ?int[] $toselect
+@phan-var-force ?string $diroutputmassaction
+';
+
 
 // Protection
 if (empty($objectclass) || empty($uploaddir)) {
@@ -51,6 +60,7 @@
 '
 @phan-var-force "Societe"|"Contact"|"ExpenseReport"|"Partnership"|"Holiday"|"ConferenceOrBoothAttendee"|"Facture"|"CommandeFournisseur" $objectclass
 @phan-var-force string $massaction
+@phan-var-force string $uploaddir
 ';
 
 
@@ -1282,6 +1292,7 @@
 
 if (!$error && ($action == 'updateprice' && $confirm == 'yes') && $permissiontoadd) {
 	'@phan-var-force Product|ProductCustomerPrice $obj';
+	'@phan-var-force Product|ProductCustomerPrice $object';
 	$nbok = 0;
 	$db->begin();
 	if (GETPOSTISSET('pricerate')) {
@@ -1377,7 +1388,7 @@
 				$res = $object->add_contact($usertoaffect, $projectrole, 'internal');
 				if ($res >= 0) {
 					$taskstatic = new Task($db);
-					$task_array = $taskstatic->getTasksArray(0, 0, $object->id, 0, 0);
+					$task_array = $taskstatic->getTasksArray(null, null, $object->id, 0, 0);
 
 					foreach ($task_array as $task) {
 						$tasksToAffect = new Task($db);
@@ -1625,7 +1636,7 @@
 				continue;
 			}
 			if ($user->id == $objecttmp->fk_validator) {
-				$objecttmp->oldcopy = dol_clone($objecttmp, 2);
+				$objecttmp->oldcopy = dol_clone($objecttmp, 2);  // @phan-suppress-current-line PhanTypeMismatchProperty
 
 				$objecttmp->date_valid = dol_now();
 				$objecttmp->fk_user_valid = $user->id;
@@ -1733,6 +1744,7 @@
 }
 
 if (!$error && ($massaction == 'increaseholiday' || ($action == 'increaseholiday' && $confirm == 'yes')) && $permissiontoapprove) {
+	'@phan-var-force Holiday $holiday';  // Supposing that $holiday is set, it is needed.
 	$db->begin();
 	$objecttmp = new $objectclass($db);
 	$nbok = 0;