Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 20.0 button dropdown part02 #31217

Open
wants to merge 4 commits into
base: 20.0
Choose a base branch
from

Conversation

thersane-john
Copy link
Contributor

@thersane-john thersane-john commented Oct 1, 2024

need #31215 PR before

FIX Ajax loaded button

see comment

FIX Abusive Url completion

Dropdown url doesn't work for non core url or javascript url

I have created an anonymous function to factor code during the fix

FIX inconsistent case isDropDown => isDropdown

keep isDropdown not isDropDown because Dropdown is used as a word

@eldy Sorry I can't split this one... the 3 problems are in same part of code.

@@ -1321,7 +1321,7 @@ function price2numjs(amount) {


jQuery(document).ready(function() {
jQuery(".butAction.dropdown-toggle").on("click", function(event) {
jQuery(document).on("click", ".butAction.dropdown-toggle", function(event) {
Copy link
Contributor Author

@thersane-john thersane-john Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix ajax loaded button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant