fix: stop screenreaders from reading duplicate accordion toggle btns #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
sravichandran-eightfold
approved these changes
Aug 7, 2024
szhang-eightfold
approved these changes
Aug 7, 2024
jhoward-eightfold
added a commit
that referenced
this pull request
Aug 8, 2024
…867) * fix: prevent screen readers from accessing duplicate accordion toggle buttons --------- Co-authored-by: Jeff Howard <>
jhoward-eightfold
added a commit
that referenced
this pull request
Aug 14, 2024
…le btns (#867) * fix: prevent screen readers from accessing duplicate accordion toggle buttons --------- Co-authored-by: Jeff Howard <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
This change takes the toggle button out of the tabIndex and gives it a presentation role, relying on the full header click area to provide keyboard support and focus for the accordion toggle. it also points to the header content as a describedBy so its read in addition to the generic button label. Both of these can be overwritten on a case-by-case basis.
GITHUB ISSUE (Open Source Contributors)
#866
JIRA TASK (Eightfold Employees Only):
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
yarn storybook)