Few critical bugs are fixed #97
Conversation
| writeBuffer = ByteBuffer.allocate(writeBufferSize); | ||
| this.objectBufferSize = objectBufferSize; | ||
| lengthLength = serialization.getLengthLength(); | ||
| writeBuffer = ByteBuffer.allocate(Math.max(writeBufferSize, lengthLength + objectBufferSize)); |
There was a problem hiding this comment.
Why not use the write buffer size that was passed in?
There was a problem hiding this comment.
Because bufferSize >= lengthLength + objectSize must be true in all cases.
If it is not so, user has entered incorrect values. We can react on that two ways:
first - throw an exception, second - use max(bufferSize, lengthLength + objectSize).
We have chosen second one, but we can change to exception.
There was a problem hiding this comment.
Thanks, I prefer an exception to using a buffer size other than what was specified.
|
Combining multiple fixes in the same PR makes review difficult. Please explain the fixes. |
|
Should we delete that PR and resubmit few new? Or comments we have written is enough? |
|
So what should we do now? |
|
@NathanSweet Any news on this? |
merge with EsotericSoftware:master
|
Splitting it into multiple PRs would help a lot. |
…tered classes lists" on/off
Dsx 2: Check classes registered in the client and the server are the same
Few bug fixes included.
In each commit there is test that fails without fix commit and doesn't fail with it.