Fix inaccurate online player count for Discord leave message (#5440)

fixes #5256
EssentialsX · Jul 23, 2023 · 52c9ca8 · 52c9ca8
1 parent f26e1b2
commit 52c9ca8
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/EssentialsDiscord/src/main/java/net/essentialsx/discord/listeners/BukkitListener.java b/EssentialsDiscord/src/main/java/net/essentialsx/discord/listeners/BukkitListener.java
@@ -119,7 +119,7 @@ public void onVanishStatusChange(VanishStatusChangeEvent event) {
     }
 
     public void sendJoinQuitMessage(final Player player, final String message, MessageType type) {
-        int userCount = jda.getPlugin().getEss().getUsers().getUserCount();
+        int onlineCount = jda.getPlugin().getEss().getOnlinePlayers().size();
         final MessageFormat format;
         switch (type.getKey()) {
             case "join":
@@ -130,7 +130,7 @@ public void sendJoinQuitMessage(final Player player, final String message, Messa
                 break;
             default: // So that it will always be initialised. Other options shouldn't be possible.
                 format = jda.getSettings().getQuitFormat(player);
-                userCount = userCount - 1;
+                onlineCount = onlineCount - 1;
                 break;
 
         }
@@ -139,8 +139,8 @@ public void sendJoinQuitMessage(final Player player, final String message, Messa
                         MessageUtil.sanitizeDiscordMarkdown(player.getName()),
                         MessageUtil.sanitizeDiscordMarkdown(player.getDisplayName()),
                         MessageUtil.sanitizeDiscordMarkdown(message),
-                        jda.getPlugin().getEss().getOnlinePlayers().size(),
-                        userCount),
+                        onlineCount,
+                        jda.getPlugin().getEss().getUsers().getUserCount()),
                         player);
     }