Fix null check for I18n error logging #5472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JRoy
approved these changes
Aug 7, 2023
JRoy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Information
This PR fixes #nnnn.
Details
Proposed fix:
This fix should potentially apply the initial intention of author for checking the nullability of ess (IEssentials). As the current code doesn't make any sense at least in way that checking if ess is null and then using that same ess var for getting a logger even thought it's ess is null.
Environments tested:
OS:
Edition Windows 11 Enterprise Insider Preview
Version 22H2
Installed on 7/25/2023
OS build 23506.1000
Experience Windows Feature Experience Pack 1000.23506.1000.0
Java version:
Demonstration: