GH-85 Add delivery codes #85

Jakubk15 · 2023-10-15T09:10:11Z

Resolves #67

…codes

...n/java/com/eternalcode/parcellockers/deliverycode/repository/DeliveryCodeRepositoryImpl.java

imDMK · 2023-10-22T11:46:28Z

...n/java/com/eternalcode/parcellockers/deliverycode/repository/DeliveryCodeRepositoryImpl.java

+        if (this.cache.get(parcelUUID) != null) {
+            return Optional.of(this.cache.get(parcelUUID));
+        }
+        return Optional.ofNullable(this.findByUUID(parcelUUID).join());


Suggested change

if (this.cache.get(parcelUUID) != null) {

return Optional.of(this.cache.get(parcelUUID));

}

return Optional.ofNullable(this.findByUUID(parcelUUID).join());

Optional<DeliveryCode> deliveryCodeOptional = Optional.ofNullable(this.cache.get(parcelUUID));

if (deliveryCodeOptional.isPresent()) {

return deliveryCodeOptional;

}

return this.findByUUID(parcelUUID).join();

ten optional słabo wygląda

To mam revertować te optionale?

You can also do this:
Optional.ofNullable(this.cache.get(parcelUUID)).or(() -> this.findByUUID(parcelUUID).join));

**sorry, że piszę po polsku zapomniałem, że nie wolno.

PL: Ogólnie to pakowanie w optionala w tym samym scope i go sprawdzanie mija się z celem np.:
EN: Packing an optional in the same scope and checking it is pointless

Optional optional = Optional.ofNullable(getNullable()); if (optional.isEmpty()) { // .... }

PL: to co zrobił DMK jest już dobre
EN: what DMK has done is already good

return Optional.ofNullable(this.cache.get(parcelUUID)).or(() -> this.findByUUID(parcelUUID).join));

3,
PL: Robienie tutaj join mija się z celem i jest też kompletnie bez kontekstu (bez use case)
EN: join() here is pointless and is also completely without context (without use case)

EN: Cache should only be in the worst possible case. please remove it

...n/java/com/eternalcode/parcellockers/deliverycode/repository/DeliveryCodeRepositoryImpl.java

…itory/DeliveryCodeRepositoryImpl.java Co-authored-by: DMK <[email protected]>

Rollczi

giga jest dużo code style zmian, a samego kodu biznesowego nie widzę... nawet nie ma tutaj use case...

there are a lot of code styles, I can't see the change in the business code itself... there's not even a use case here...

Rollczi · 2023-10-22T16:49:52Z

...n/java/com/eternalcode/parcellockers/deliverycode/repository/DeliveryCodeRepositoryImpl.java

+
+public class DeliveryCodeRepositoryImpl extends AbstractDatabaseService implements DeliveryCodeRepository {
+
+    private final Map<UUID, DeliveryCode> cache = new HashMap<>();


ja bym cache nie dodawał dopóki nie będzie realnego usecase gdzie będzie to potrzebne

Będzie realny use case bardzo niedługo, na razie zostawiam, w razie co to usunę

Jakubk15 · 2023-10-22T18:43:37Z

@Rollczi Nie ma use case, bo delivery code mają być generowane przy dojściu paczki do Lockera, a nie ma zrobionych jeszcze timed tasków i eventów pod to, więc póki co tworzę sobie obiekty i bazę danych, żeby w przyszłych PR nie było potworków. Wszystkie zmiany related do kodów odbioru są w paczce deliverycode. Pozdrawiam cieplutko

...n/java/com/eternalcode/parcellockers/deliverycode/repository/DeliveryCodeRepositoryImpl.java

Co-authored-by: DMK <[email protected]>

Rollczi

I'm waiting for resolve:

Jakubk15 · 2023-10-23T04:47:43Z

@Rollczi Nie ma use case, bo delivery code mają być generowane przy dojściu paczki do Lockera, a nie ma zrobionych jeszcze timed tasków i eventów pod to, więc póki co tworzę sobie obiekty i bazę danych, żeby w przyszłych PR nie było potworków. Wszystkie zmiany related do kodów odbioru są w paczce deliverycode. Pozdrawiam cieplutko

As I said above, I can't simply make this PR a monster.

Jakubk15 · 2023-10-23T04:48:33Z

The Optional you requested has been changed. I believe that using cache with #join will be used really carefully and in necessary situations, as I already did in many GUIs.

Rollczi · 2023-10-23T06:50:04Z

@Rollczi Nie ma use case, bo delivery code mają być generowane przy dojściu paczki do Lockera, a nie ma zrobionych jeszcze timed tasków i eventów pod to, więc póki co tworzę sobie obiekty i bazę danych, żeby w przyszłych PR nie było potworków. Wszystkie zmiany related do kodów odbioru są w paczce deliverycode. Pozdrawiam cieplutko

As I said above, I can't simply make this PR a monster.

Remove cache from repo impl

Jakubk15 added 5 commits October 14, 2023 22:43

Add DeliveryCode package and its objects

422f76e

Merge branch 'master' into add-delivery-codes

8baeb0f

Implement DeliveryCodeRepository

7045e50

Fix build

7691d21

Fix codestyle

88f9f0f

Jakubk15 changed the title ~~Add delivery codes~~ GH-85 Add delivery codes Oct 15, 2023

Jakubk15 and others added 7 commits October 15, 2023 11:11

Merge branch 'master' into add-delivery-codes

bf71e95

Merge branch 'master' into add-delivery-codes

723a0dc

Fix build

c4cd56e

Update all dependencies

339200e

Merge branch 'master' into add-delivery-codes

e301cf4

Merge remote-tracking branch 'origin/renovate/all' into add-delivery-…

71e58fe

…codes

Bump dependencies, fix build

6ab80e0

Jakubk15 marked this pull request as ready for review October 22, 2023 11:28

Jakubk15 requested review from imDMK, Rollczi, vLuckyyy and igoyek October 22, 2023 11:28

igoyek previously approved these changes Oct 22, 2023

View reviewed changes

Don't use experimental spigot-api

7b1770c

Jakubk15 dismissed igoyek’s stale review via 7b1770c October 22, 2023 11:45

vLuckyyy previously approved these changes Oct 22, 2023

View reviewed changes

imDMK requested changes Oct 22, 2023

View reviewed changes

Update src/main/java/com/eternalcode/parcellockers/deliverycode/repos…

eb726db

…itory/DeliveryCodeRepositoryImpl.java Co-authored-by: DMK <[email protected]>

Jakubk15 dismissed vLuckyyy’s stale review via eb726db October 22, 2023 12:00

Jakubk15 and others added 3 commits October 22, 2023 14:00

Update src/main/java/com/eternalcode/parcellockers/deliverycode/repos…

51c21dc

…itory/DeliveryCodeRepositoryImpl.java Co-authored-by: DMK <[email protected]>

Update src/main/java/com/eternalcode/parcellockers/deliverycode/repos…

420e490

…itory/DeliveryCodeRepositoryImpl.java Co-authored-by: DMK <[email protected]>

Update src/main/java/com/eternalcode/parcellockers/deliverycode/repos…

745de67

…itory/DeliveryCodeRepositoryImpl.java Co-authored-by: DMK <[email protected]>

Jakubk15 requested a review from imDMK October 22, 2023 12:01

Fix whitespaces

af611fe

Rollczi requested changes Oct 22, 2023

View reviewed changes

Apply PR suggestions

c9eac0b

Jakubk15 requested a review from Rollczi October 22, 2023 20:06

imDMK requested changes Oct 22, 2023

View reviewed changes

...n/java/com/eternalcode/parcellockers/deliverycode/repository/DeliveryCodeRepositoryImpl.java Outdated Show resolved Hide resolved

Update DeliveryCodeRepositoryImpl.java

8ad6647

Co-authored-by: DMK <[email protected]>

Jakubk15 requested a review from imDMK October 22, 2023 20:32

imDMK approved these changes Oct 22, 2023

View reviewed changes

Rollczi requested changes Oct 22, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GH-85 Add delivery codes #85

GH-85 Add delivery codes #85

Jakubk15 commented Oct 15, 2023 •

edited

Loading

imDMK Oct 22, 2023

Rollczi Oct 22, 2023

Jakubk15 Oct 22, 2023

imDMK Oct 22, 2023 •

edited

Loading

Rollczi Oct 22, 2023

Rollczi left a comment •

edited

Loading

Rollczi Oct 22, 2023

Jakubk15 Oct 22, 2023

Jakubk15 commented Oct 22, 2023

Rollczi left a comment

Jakubk15 commented Oct 23, 2023

Jakubk15 commented Oct 23, 2023 •

edited

Loading

Rollczi commented Oct 23, 2023

-        if (this.cache.get(parcelUUID) != null) {
-            return Optional.of(this.cache.get(parcelUUID));
-        }
-        return Optional.ofNullable(this.findByUUID(parcelUUID).join());
+       Optional<DeliveryCode> deliveryCodeOptional = Optional.ofNullable(this.cache.get(parcelUUID));
+       if (deliveryCodeOptional.isPresent()) {
+           return deliveryCodeOptional;
+       }
+        return this.findByUUID(parcelUUID).join();


		public class DeliveryCodeRepositoryImpl extends AbstractDatabaseService implements DeliveryCodeRepository {

		private final Map<UUID, DeliveryCode> cache = new HashMap<>();

GH-85 Add delivery codes #85

Are you sure you want to change the base?

GH-85 Add delivery codes #85

Conversation

Jakubk15 commented Oct 15, 2023 • edited Loading

imDMK Oct 22, 2023

Choose a reason for hiding this comment

Rollczi Oct 22, 2023

Choose a reason for hiding this comment

Jakubk15 Oct 22, 2023

Choose a reason for hiding this comment

imDMK Oct 22, 2023 • edited Loading

Choose a reason for hiding this comment

Rollczi Oct 22, 2023

Choose a reason for hiding this comment

Rollczi left a comment • edited Loading

Choose a reason for hiding this comment

Rollczi Oct 22, 2023

Choose a reason for hiding this comment

Jakubk15 Oct 22, 2023

Choose a reason for hiding this comment

Jakubk15 commented Oct 22, 2023

Rollczi left a comment

Choose a reason for hiding this comment

Jakubk15 commented Oct 23, 2023

Jakubk15 commented Oct 23, 2023 • edited Loading

Rollczi commented Oct 23, 2023

Jakubk15 commented Oct 15, 2023 •

edited

Loading

imDMK Oct 22, 2023 •

edited

Loading

Rollczi left a comment •

edited

Loading

Jakubk15 commented Oct 23, 2023 •

edited

Loading