Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A bunch of small improvements while working on the wizard back and resume #556

Merged
merged 4 commits into from
Sep 23, 2024
Merged

A bunch of small improvements while working on the wizard back and resume #556

merged 4 commits into from
Sep 23, 2024

Commits on Sep 23, 2024

  1. fix: make the Windows warning about no sox a fatal error 

    For dev't purposes, we want to be able to skip it, but let's force the
dev to set an env variable to do so, instead of using a warning that
might be missed if someone does not look at the logs.
    @joanise
    joanise committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    5f246e8 View commit details
    Browse the repository at this point in the history

  2. fix: make sure validate does not leave partial directories behind

    @joanise
    joanise committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    2d2dbee View commit details
    Browse the repository at this point in the history

  3. fix: make more test suites compatible with Windows 

     - refactor: test_configs use readalongs PortableNamedTmpFile
   allows more unit tests to pass on Windows.
 - make test_utils.py compatible with Windows by expecting either
   windows or posix paths
    @joanise
    joanise committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    ac9b295 View commit details
    Browse the repository at this point in the history

  4. refactor: move test harness code out of Step into TestStep 

    also:
 - document the methods in the wizard's Tour class
 - remove the unused child_index arg to add_step
    @joanise
    joanise committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    6d7a98f View commit details
    Browse the repository at this point in the history