-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow RequestParam and FileParam to target class #2405
Conversation
Hi @goetas Just saw you on the pr 2401 and was seeking for the maintainer. Hopefully I reached the right person to know how we could manage this PR. 🙂 I thought it would be nice to be merged before and maybe make a release (hopefully not too late because of the last merge 😟 ) to allow a more flexible usage of the current attributes. Please let me know if I need to target another branch or if the improvement will be merged once SF7 compatibility is achieved. Thank you. |
Ooo, I saw this too late... Sorry 😔 |
I did copy it into #2400 so it's there. |
No problem. Thank you. I keep an eye on the bundle as a lot of people. I will close this pr once the other is merged or close it now if you think it's more appropriate. |
I looked at your comment and pr on the phone and didn't see that the other pr was merged and a release was made. Thank you for allowing the update! 🙂 |
Hi,
To be consistent across the different available params and be able to place them on class, it requires to add
\Attribute::TARGET_CLASS
to theRequestParam
andFileParam
.I added the annotation for compatibility too.
Hopefully this can be merged and release before #2400 as they may be incompatible.
Thanks
[edit]: Actions seems to be broken due to composer.json or lock file. Not sure how to resolve. Let me know if I can help on this too.