Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken error handling around Idempotent producer + Ensure strict ordering when Net.MaxOpenRequests = 1 #2943

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Fix broken error handling around Idempotent producer + Ensure strict ordering when Net.MaxOpenRequests = 1 #2943

wants to merge 14 commits into from

Commits on Jul 19, 2024

  1. sync produce 

    Signed-off-by: Richard Artoul <[email protected]>
    @richardartoul
    richardartoul committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    0a07760 View commit details
    Browse the repository at this point in the history

  2. add sequence for retries 

    Signed-off-by: Richard Artoul <[email protected]>
    @richardartoul
    richardartoul committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    78b02d0 View commit details
    Browse the repository at this point in the history

  3. panic if no sequence 

    Signed-off-by: Richard Artoul <[email protected]>
    @richardartoul
    richardartoul committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    46d19e5 View commit details
    Browse the repository at this point in the history

  4. maintain producer ID and epoch when retrying batch 

    Signed-off-by: Richard Artoul <[email protected]>
    @richardartoul
    richardartoul committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    e715c7d View commit details
    Browse the repository at this point in the history

  5. panic out of order 

    Signed-off-by: Richard Artoul <[email protected]>
    @richardartoul
    richardartoul committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    d22f96f View commit details
    Browse the repository at this point in the history

  6. wip 

    Signed-off-by: Richard Artoul <[email protected]>
    @richardartoul
    richardartoul committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    337aab2 View commit details
    Browse the repository at this point in the history

  7. improve and add comments 

    Signed-off-by: Richard Artoul <[email protected]>
    @richardartoul
    richardartoul committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    b7cc6fc View commit details
    Browse the repository at this point in the history

  8. remove unnecessary check 

    Signed-off-by: Richard Artoul <[email protected]>
    @richardartoul
    richardartoul committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    82e8795 View commit details
    Browse the repository at this point in the history

  9. better comment 

    Signed-off-by: Richard Artoul <[email protected]>
    @richardartoul
    richardartoul committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    401c990 View commit details
    Browse the repository at this point in the history

  10. Add kafkastorageerror as retriable 

    Signed-off-by: Richard Artoul <[email protected]>
    @richardartoul
    richardartoul committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    2d7cdb6 View commit details
    Browse the repository at this point in the history

  11. fix typo 

    Signed-off-by: Richard Artoul <[email protected]>
    @richardartoul
    richardartoul committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    1cf850b View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2024

  1. improve error logging

    @richardartoul
    richardartoul committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    1125d60 View commit details
    Browse the repository at this point in the history

  2. more logging

    @richardartoul
    richardartoul committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    b73a5f2 View commit details
    Browse the repository at this point in the history

  3. dont clear message before logging

    @richardartoul
    richardartoul committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    0222838 View commit details
    Browse the repository at this point in the history