Fix poetry cache error in actions #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexdewar
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
LGTM! I'll cherry-pick this directly into my poetry branch though, so I wouldn't merge it.
The Windows runner is failing because Python assumes the default encoding for files on Windows is CP1252 rather than UTF-8 (I know, gross), so you need to add encoding="utf-8") to any call to open() you make.
|
Oh, I just noticed that there is no Another thing: did you mean for this PR to be in the ICL fork of the repo or the upstream one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the failing tests
See here for the reasoning