Automatically set up the OVE sections #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CWestICL
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Code all looks good and managed to get the OVE sections generated when testing (eventually). The develop tag for running config.py currently doesn't work as it uses the 9.9.9 images located on Adrian's local machine. Not using the develop tag also caused issues with the dash image and I had to manually change the image: tag to build: .. Other than that, seems to be working as intended
AdrianDAlessandro
force-pushed
the
auto-setup
branch
from
8912140
to
2b1f01e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the functionality to automatically set up the OVE sections and changes the core_api calls so that the WebRTC apps are set up where they are needed.
Close #6