Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add Flora helper methods" #299

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

davidorme
Copy link
Collaborator

Reverts #296

Adding all of this in one go and then restructuring it in bits makes for a horrible mess. The problem is that the cleaner structures we're aiming for don't work well as parts if the current structure. So building it up a bit at a time from scratch avoids horrible hacky patches.

@davidorme davidorme marked this pull request as ready for review September 27, 2024 16:04
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.54%. Comparing base (1f315ba) to head (f6d0c57).
Report is 145 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #299      +/-   ##
===========================================
+ Coverage    95.29%   95.54%   +0.25%     
===========================================
  Files           28       34       +6     
  Lines         1720     2243     +523     
===========================================
+ Hits          1639     2143     +504     
- Misses          81      100      +19     
Flag Coverage Δ
95.54% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidorme davidorme merged commit 5b3e361 into develop Sep 27, 2024
12 checks passed
@davidorme davidorme deleted the revert-296-290-add-pft-helper-functions branch September 27, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants