-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CrownProfile
class
#311
Conversation
Update canopy profile branch with stem allocation changes.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #311 +/- ##
===========================================
+ Coverage 95.84% 95.87% +0.03%
===========================================
Files 34 34
Lines 2404 2427 +23
===========================================
+ Hits 2304 2327 +23
Misses 100 100
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
… more detailed tests
@MarionBWeinzierl I've renamed those files as suggested and updated the references in docs and code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for fixing the docstrings.
Description
This PR:
CrownProfile
class, which takes:Flora
orStemTraits
,StemAllometry
instance, andcrown
systematically when referring to individual stem predictions, retaining canopy for the community wide combination of multiple stems in theCanopy
class.canopy_functions.py
toflora.py
- these calculate PFT traits (and in factflora.py
would be better astraits.py
) and moving them avoids circular imports.calculate_(canopy/crown)_q_m
calculate_(canopy/crown)_z_max_proportion
canopy_functions.py
tot_model_functions.py
- these calculate scaling allometries like the other functions in this module and moving them avoids circular imports.calculate_(canopy/crown)_z_max
calculate_(canopy/crown)_r0
Fixes #309
Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest
Further checks