PR #13354 from Nir-Az: Fix spatial filter BUG

IntelRealSense · Sep 18, 2024 · 557489e · 557489e
2 parents 2375063 + b0783a5
commit 557489e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/proc/spatial-filter.cpp b/src/proc/spatial-filter.cpp
@@ -119,7 +119,7 @@ namespace librealsense
         holes_filling_mode->set_description(sp_hf_16_pixel_radius, "16-pixel radius");
         holes_filling_mode->set_description(sp_hf_unlimited_radius, "Unlimited");
 
-        auto weak_holes_filling_mode = std::weak_ptr<ptr_option<uint8_t>>();
+        auto weak_holes_filling_mode = std::weak_ptr<ptr_option<uint8_t>>(holes_filling_mode);
         holes_filling_mode->on_set([this, weak_holes_filling_mode](float val)
         {
             auto strong_holes_filling_mode = weak_holes_filling_mode.lock();

diff --git a/src/proc/spatial-filter.h b/src/proc/spatial-filter.h
@@ -48,6 +48,7 @@ namespace librealsense
 
             // Disparity domain hole filling requires a second pass over the frame data
             // For depth domain a more efficient in-place hole filling is performed
+            // No need to lock the '_holes_filling_mode' or '_holes_filling_radius' as they are locked at the processing block scope
             if (_holes_filling_mode && fp)
                 intertial_holes_fill<T>(static_cast<T*>(frame_data));
         }