Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch2 v3.4 as static lib; U22 in GHA #12257

Merged
merged 4 commits into from
Oct 5, 2023
Merged

Catch2 v3.4 as static lib; U22 in GHA #12257

merged 4 commits into from
Oct 5, 2023

Conversation

maloel
Copy link
Collaborator

@maloel maloel commented Oct 4, 2023 •
edited
Loading

  • Upgrade Catch2 to v3.4 (from v2.12.1)
  • Now U22-compatible
  • Catch2 is now an external project that's cloned during configuration (but only if BUILD_UNIT_TESTS or BUILD_LEGACY_LIVE_TEST are on)
  • Two possible link targets (Catch2 and Catch2WithMain) are static libs under ExternalProjectTargets in V.Studio
  • Updated 2 GHA jobs from U20 to U22

Tracked on [LRS-905] and [LRS-912]

@maloel maloel requested review from dmipx and Nir-Az and removed request for dmipx October 4, 2023 19:18
Nir-Az
Nir-Az approved these changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@Nir-Az Nir-Az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see the minimal cmake test that fails.
I rerun and it failed again.
Looks like a CI issue, let's try again in a few hours

@maloel maloel merged commit 25b4b59 into IntelRealSense:development Oct 5, 2023
17 checks passed
@maloel maloel deleted the u22 branch October 5, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nir-Az Nir-Az Nir-Az approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maloel @Nir-Az