Coverity & rs-dds-config fix #13338
Merged
Coverity & rs-dds-config fix #13338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OhadMeir
approved these changes
Sep 12, 2024
OhadMeir
reviewed
Sep 16, 2024
| if( rv != sizeof( incr ) ) | ||
| LOG_WARNING( "failed to write to network adapter watcher done event: " << rv ); | ||
| else | ||
| _th.join(); |
There was a problem hiding this comment.
If we don't join, it will cause program abnormal termination. Maybe retry to signal?
There was a problem hiding this comment.
This is just to avoid a hang if the write fails (it failed and hung); it's not expected once done right (and now it is)
There was a problem hiding this comment.
OK, if write fails it's probably an OS error and it means we won't close gracefully. I think it's acceptable.
OhadMeir
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rs-dds-config needs to always assume DDS enabled, but didn't...
Fix High Coverity issues.
rs-colorexample didn't work with non-standard resolutions. Fixed.