Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix: refatored how shell & tools are provided #4969

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Conversation

coot
Copy link
Contributor

@coot coot commented Sep 28, 2024

No description provided.

@coot coot requested review from a team as code owners September 28, 2024 08:12
@coot coot requested a review from bolt12 September 28, 2024 08:12
@coot coot force-pushed the coot/nix-devShells branch 2 times, most recently from eef86fb to ad1f3d8 Compare September 28, 2024 08:46
Copy link
Contributor

@semanticphilosopher semanticphilosopher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems reasonable to me

@coot
Copy link
Contributor Author

coot commented Sep 28, 2024

@semanticphilosopher I am stealing ideas from the ouroboros-consensus repo, without making it too hard to understand what's going on.

@coot
Copy link
Contributor Author

coot commented Sep 28, 2024

@semanticphilosopher you need to review as @njd42, we only have your latter account in the @IntersectMBO/ouroboros-network-maintainers.

@coot coot force-pushed the coot/nix-devShells branch 5 times, most recently from 4493652 to ca9b54f Compare September 30, 2024 06:05
@coot coot self-assigned this Sep 30, 2024
@coot coot added nix This includes CI, nix changes or cabal dependencies CI Issues / PRs related to CI labels Sep 30, 2024
@coot coot force-pushed the coot/nix-devShells branch 7 times, most recently from 9685d18 to 0563ea6 Compare September 30, 2024 08:26
#
# CHaP
# ----

# CHaP input map, so we can find CHaP packages (needs to be more
# recent than the index-state we set!). Can be updated with
# recenbt than the index-state we set!). Can be updated with
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@coot coot force-pushed the coot/nix-devShells branch 3 times, most recently from cd955cf to 230f12b Compare September 30, 2024 12:53
We no longer use `srp` for dependency management, thus the script is no
longer needed.
* Added explicit cabal.project
* Removed `-Werror` flags in nix, they are set in `cabal.project.local`
  files.
* Used `doCheckCross` instead of setting `doCheck` flag per package.
```
nix develop .\#profiling
```

It will enter a nix shell with profiling environment for `ghc-9.8`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Issues / PRs related to CI nix This includes CI, nix changes or cabal dependencies
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants