Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect reversion of history #146

Open
jenniferColonell opened this issue Apr 3, 2020 · 0 comments
Open

Incorrect reversion of history #146

jenniferColonell opened this issue Apr 3, 2020 · 0 comments

Comments

@jenniferColonell
Copy link
Contributor

jenniferColonell commented Apr 3, 2020

Reversion of many steps (3-5) from the history can result in incorrect cluster labels. Observed with long recordings, eg. 2-3 hours recordings of 384 channels.

For about 20% of revert operations, some or all of the reverted steps are not removed from the history as displayed in the "History" pull down menu. This can be true even though the steps were correctly executed-- i.e. the cluster labels are correct. After saving the sort and re-starting manual curation, the history displayed is correct. (confirmed with JRCLUST v4.0.1 "Edward" (c584685)).

On recordings of any length, annotations are not handled correctly when reverting. Annotations remain "stuck" at the cluster assignment at the start of the revision, and don't get updated as the cluster labels change due to reverting merges and splits. (confirmed with JRCLUST v4.0.1 "Edward" (c584685)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant