Re-implement prompt builder & make it public #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vladislav0Art
added
improvement
Vladislav0Art
added
In progress
added 13 commits
September 25, 2024 14:29
Make `PromptBuilder` assert that the client inserts all mandatory keywords.
This version includes all the changes of `PromptBuilder` on commit 1284ab4.
Vladislav0Art
force-pushed
the
vartiukhov/feature/enhance-prompt-builder
branch
from
15fe4ba
to
3756c8a
Compare
Vladislav0Art
requested review from
pderakhshanfar,
arksap2002 and
Hello-zoka
and removed request for
pderakhshanfar
Vladislav0Art
added
Ready for review
pderakhshanfar
approved these changes
Sep 26, 2024
Hello-zoka
approved these changes
Sep 26, 2024
...src/main/kotlin/org/jetbrains/research/testspark/core/generation/llm/prompt/PromptBuilder.kt
Outdated
Show resolved
Hide resolved
|
Published 3.0.0 version of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes made
PromptBuilderand introduce validation of the prompt keywords inserted.PromptBuilderwith unit tests.PromptBuilderpublic so client code has more control over prompt generation (required by the Fleet plugin).Why is a merge request needed
coremodule.PromptBuilderin a more robust manner.Other notes
Closes #291
What is missing?
2.0.8because previouslyPromptBuilderwas not accessible (i.e., marked asinternal). Therefore, no client code can observe the introduced modifications toPromptBuilder's API.3.0.0because API ofPromptKeywordhas changed (namely,textmember field was removed).2.0.5, which should come intodevelopmentbefore the current version2.0.7.