[kotlin][idea] Fixed cross-language ChangeAnnotationAction for java annotations used in kotlin code. #2852
+322
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the problem with
JvmElementActionsFactory#createChangeAnnotationAttributeActions
.When executing
invoke
, if we modify, for example, a class in Kotlin that uses java annotations, then the attributes are not assigned correctly. I found this bug while migrating to K2.Java Annotations work differently than Kotlin Annotations in Kotlin code. Because varargs for an array do not exist in Kotlin annotations. After all, kotlin supports java syntax if annotation is from a Java source file.
How to reproduce a bug
IDE Opened project
Permission.java
SomeCode.kt
IDE Plugin
Before my changes
SomeCode.kt
After my changes
SomeCode.kt