Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: Carbon v1.0.0 #93438

Closed

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator JuliaRegistrator commented Oct 15, 2023

@cormullion
Copy link

[noblock] This looks a bit like a test package ... 🤔

@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2023

Your new package pull request does not meet the guidelines for auto-merging. Please make sure that you have read the General registry README and the AutoMerge guidelines. The following guidelines were not met:

  • The following dependencies do not have a [compat] entry that is upper-bounded and only includes a finite number of breaking releases: Documenter
  • Package name similar to 2 existing packages.
    1. Similar to Chron. Damerau-Levenshtein distance 2 is at or below cutoff of 2.
    2. Similar to Carlo. Damerau-Levenshtein distance 2 is at or below cutoff of 2.

Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human.

After you have fixed the AutoMerge issues, simple retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your Project.toml file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number).

If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. Then, send a message to the #pkg-registration channel in the Julia Slack to ask for help. Include a link to this pull request.

Since you are registering a new package, please make sure that you have also read the package naming guidelines: https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment. You can edit blocking comments, adding [noblock] to them in order to unblock auto-merging.

@JuliaRegistrator JuliaRegistrator force-pushed the registrator-carbon-c6408494-v1.0.0-830bf92c7d branch from b00a9f0 to d6670bf Compare October 15, 2023 17:05
@JuliaRegistrator JuliaRegistrator temporarily deployed to stopwatch October 15, 2023 17:05 — with GitHub Actions Inactive
@vrkansagara
Copy link

[noblock] This looks a bit like a test package ... 🤔

@cormullion Please check latest state

@JuliaRegistrator JuliaRegistrator force-pushed the registrator-carbon-c6408494-v1.0.0-830bf92c7d branch from d6670bf to 0600bd2 Compare October 15, 2023 17:44
@JuliaRegistrator JuliaRegistrator temporarily deployed to stopwatch October 15, 2023 17:44 — with GitHub Actions Inactive
@cormullion
Copy link

[noblock] This looks a bit like a test package ... 🤔

@cormullion Please check latest state

I don't think code like this needs to be in a package?

function now()
    return DateTime(2023)
end

@JuliaRegistrator JuliaRegistrator force-pushed the registrator-carbon-c6408494-v1.0.0-830bf92c7d branch from 0600bd2 to 094e452 Compare October 15, 2023 18:03
@JuliaRegistrator JuliaRegistrator temporarily deployed to stopwatch October 15, 2023 18:04 — with GitHub Actions Inactive
@vrkansagara
Copy link

@cormullion updated the code.
Can you help me with this how can I remove or solve this error.

Package name similar to 2 existing packages.
Similar to Chron. Damerau-Levenshtein distance 2 is at or below cutoff of 2.
Similar to Carlo. Damerau-Levenshtein distance 2 is at or below cutoff of 2.

@JuliaRegistrator JuliaRegistrator force-pushed the registrator-carbon-c6408494-v1.0.0-830bf92c7d branch from 094e452 to 49fd746 Compare October 15, 2023 18:49
@JuliaRegistrator JuliaRegistrator temporarily deployed to stopwatch October 15, 2023 18:49 — with GitHub Actions Inactive
@cormullion
Copy link

@cormullion updated the code. Can you help me with this how can I remove or solve this error.

Package name similar to 2 existing packages. Similar to Chron. Damerau-Levenshtein distance 2 is at or below cutoff of 2. Similar to Carlo. Damerau-Levenshtein distance 2 is at or below cutoff of 2.

There's nothing you can do now - you have to wait 3 days before a submitted package can be registered - if it's considered to be a useful addition to the registry. You can discuss the naming of your package on the Slack channel mentioned above

@briochemc
Copy link
Contributor

What does this package do? How is it related to carbon?

UUID: c6408494-260b-4f8d-aa04-3305a96ccce5
Repo: https://github.com/vrkansagara/Carbon.jl.git
Tree: 1cc09593b66b2b0826175653a03ee721fdea4f66

Registrator tree SHA: f73a20c99934db92a256057d0d83ba394036a701
@JuliaRegistrator JuliaRegistrator force-pushed the registrator-carbon-c6408494-v1.0.0-830bf92c7d branch from 49fd746 to d053061 Compare October 15, 2023 23:46
@JuliaRegistrator JuliaRegistrator temporarily deployed to stopwatch October 15, 2023 23:46 — with GitHub Actions Inactive
@vrkansagara
Copy link

Here is the explanation of the package name. Why did I choose this package name as Carbon?

There is a very good library in a different language community called Carbon , From where I was inspired to take the name and it has a very friendly implementation of the DateTime

There is no actual Carbon relating to this package nor relating to any chemical or substance relating in this package name

cc: @cormullion @briochemc

@briochemc
Copy link
Contributor

briochemc commented Oct 16, 2023

I think there are a few problems here:

  1. This package looks empty. No point in registering it at this stage.
  2. It is not clear what this package intends to do. Please add some description/example of what people might use this for in your ReadMe at least.
  3. The name choice is not good. If you call a package "Carbon.jl", people will expect it to have something to do with the most common definition of carbon, not a very specific PHP API. Try to think of a name that will be meaningful to a random Julia user.

@vrkansagara
Copy link

noted with thanks @briochemc , I have just changed the package name.

@vrkansagara
Copy link

vrkansagara commented Oct 16, 2023

@JuliaRegistrator
This issue should be closed now.

@vrkansagara
Copy link

FYI, I have changed that package name to TZ Hope this will works foryou @briochemc

@briochemc
Copy link
Contributor

No, sorry, but it does not work: The new name, "Tz", is just as confusing if not worse. But this does not matter at this stage anyway, because your package is basically empty and thus not ready for registration.

@vrkansagara
Copy link

Now I am really confused about what is the definition of an empty package here.?

@briochemc
Copy link
Contributor

briochemc commented Oct 16, 2023

I'm sorry that this is confusing to you. There's no formal definition as far as I know, but your package provides close to zero functionality. It merely contains four "Hello World!"-printing types of functions or aliases:

  • greet just prints "hello". Not useful.
  • version just prints the package version. Not useful since this functionality is built in the package manager.
  • now just prints the current time with a static format. Not really useful and overwriting the standard library's now function seems like a bad idea.
  • p is an alias for printf. Not useful. Probably errors since printf is not defined.

Anyway, What is the intended purpose of the package? Even this is not clear...

@vrkansagara
Copy link

@JuliaRegistrator Give up this PR and close it

Copy link
Contributor

This pull request has been inactive for 30 days and will be automatically closed 7 days from now. If this pull request should not be closed, please either (1) fix the AutoMerge issues and re-trigger Registrator, which will automatically update the pull request, or (2) post a comment explaining why you would like this pull request to be manually merged. [noblock]

@github-actions github-actions bot added the stale label Nov 17, 2023
Copy link
Contributor

This pull request has been inactive for more than 30 days and has automatically been closed. Feel free to register your package or version again once you fix the AutoMerge issues. [noblock]

@github-actions github-actions bot closed this Nov 24, 2023
@github-actions github-actions bot deleted the registrator-carbon-c6408494-v1.0.0-830bf92c7d branch November 24, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants