Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix JLD2 julia compat" #93526

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Oct 16, 2023

Reverts #93505

Pkg tests install MetaGraphs v0.6.4 (to test SemVer installation) which has an upper bound on JLD2 which was this PR made impossible to install on julia 1.9+

Unfortunately that means this change broke Pkg CI (which is tested on Base CI too)

add: resolve tiers: Error During Test at /home/runner/work/Pkg.jl/Pkg.jl/test/new.jl:906
  Got exception outside of a @test
  Unsatisfiable requirements detected for package JLD2 [033835bb]:
   JLD2 [033835bb] log:
   ├─possible versions are: 0.1.0 - 0.4.35 or uninstalled
   ├─restricted by julia compatibility requirements to versions: 0.4.28 - 0.4.35 or uninstalled
   └─restricted by compatibility requirements with MetaGraphs [626554b9] to versions: 0.1.0 - 0.1.14 — no versions left
     └─MetaGraphs [626554b9] log:
       ├─possible versions are: 0.5.0 - 0.7.2 or uninstalled
       └─restricted to versions 0.6.4 by an explicit requirement, leaving only versions: 0.6.4
(@v1.9) pkg> add [email protected]
   Resolving package versions...
ERROR: Unsatisfiable requirements detected for package JLD2 [033835bb]:
 JLD2 [033835bb] log:
 ├─possible versions are: 0.1.0-0.4.35 or uninstalled
 ├─restricted by julia compatibility requirements to versions: 0.4.28-0.4.35 or uninstalled
 └─restricted by compatibility requirements with MetaGraphs [626554b9] to versions: 0.1.0-0.1.14 — no versions left
   └─MetaGraphs [626554b9] log:
     ├─possible versions are: 0.5.0-0.7.2 or uninstalled
     └─restricted to versions 0.6.4 by an explicit requirement, leaving only versions: 0.6.4

@IanButterworth IanButterworth temporarily deployed to stopwatch October 16, 2023 20:24 — with GitHub Actions Inactive
@DilumAluthge
Copy link
Member

For Pkg tests, if we want to make the tests more reproducible, we could checkout a specific commit of the General registry. That way, changes in the General registry won't cause the Pkg tests to fail.

@DilumAluthge DilumAluthge added the revert This reverts a previously merged PR. label Oct 16, 2023
@IanButterworth IanButterworth merged commit 3ede379 into master Oct 16, 2023
13 checks passed
@IanButterworth IanButterworth deleted the revert-93505-ib/JLD2_compat branch October 16, 2023 20:42
giordano pushed a commit that referenced this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
revert This reverts a previously merged PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants