Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: QWignerSymbols v0.1.0 #93674

Merged

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator JuliaRegistrator commented Oct 18, 2023

JuliaRegistrator referenced this pull request in lkdvos/QWignerSymbols.jl Oct 18, 2023
@JuliaRegistrator JuliaRegistrator temporarily deployed to stopwatch October 18, 2023 19:48 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Your new package pull request does not meet the guidelines for auto-merging. Please make sure that you have read the General registry README and the AutoMerge guidelines. The following guidelines were not met:

  • Package name similar to 1 existing package.
    1. Similar to WignerSymbols. Damerau-Levenshtein distance 1 is at or below cutoff of 2. Damerau-Levenshtein distance 1 between lowercased names is at or below cutoff of 1.

Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human.

After you have fixed the AutoMerge issues, simple retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your Project.toml file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number).

If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. Then, send a message to the #pkg-registration channel in the Julia Slack to ask for help. Include a link to this pull request.

Since you are registering a new package, please make sure that you have also read the package naming guidelines: https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment. You can edit blocking comments, adding [noblock] to them in order to unblock auto-merging.

@lkdvos
Copy link
Contributor

lkdvos commented Oct 18, 2023

Hi,

I would like to circumvent the package naming distance problem for this package, because the similarity to the existing WignerSymbols.jl is by design. There is a branch of mathematics that consists of q-deforming existing notions, leading to so-called q-numbers, q-factorials, etc. I specifically want to define q-WignerSymbols, stemming from the q-deformation of SU(2), for which the original wigner symbols are defined. As such I would argue that this name is chosen rather well, and might deserve an exception to the naming rule.

I agree that it is incredibly unfortunate that in this case Q and W are incredibly close together on most physical keyboards, but I guess the actual chance of mistyping might be rather small.

Thanks for your understanding!

@goerz
Copy link
Member

goerz commented Oct 18, 2023

Can you make sure that there is a usage example, either in the README or the Documentation?

The two documentation badges in the README currently have a 404 error.

@JuliaRegistrator JuliaRegistrator force-pushed the registrator-qwignersymbols-a6ec71dc-v0.1.0-0b10f70b79 branch from e922713 to 7890fcd Compare October 19, 2023 07:46
JuliaRegistrator referenced this pull request in lkdvos/QWignerSymbols.jl Oct 19, 2023
@JuliaRegistrator JuliaRegistrator temporarily deployed to stopwatch October 19, 2023 07:46 — with GitHub Actions Inactive
UUID: a6ec71dc-95d1-4ca4-9dd3-50060f27aa2b
Repo: https://github.com/lkdvos/QWignerSymbols.jl.git
Tree: b0084720748f111f2aca38c3429a280e3c7cd028

Registrator tree SHA: f73a20c99934db92a256057d0d83ba394036a701
@JuliaRegistrator JuliaRegistrator force-pushed the registrator-qwignersymbols-a6ec71dc-v0.1.0-0b10f70b79 branch from 7890fcd to 12cab36 Compare October 19, 2023 07:49
JuliaRegistrator referenced this pull request in lkdvos/QWignerSymbols.jl Oct 19, 2023
@JuliaRegistrator JuliaRegistrator temporarily deployed to stopwatch October 19, 2023 07:49 — with GitHub Actions Inactive
@ericphanson ericphanson merged commit b9fb954 into master Oct 24, 2023
8 of 10 checks passed
@ericphanson ericphanson deleted the registrator-qwignersymbols-a6ec71dc-v0.1.0-0b10f70b79 branch October 24, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants