Fix dynamically-defined properties

Kitware · Mar 30, 2024 · 06d2160 · 06d2160
1 parent e8a4aa9
commit 06d2160
Show file tree

Hide file tree

Showing 6 changed files with 26 additions and 24 deletions.
diff --git a/app/cdash/app/Model/BuildConfigure.php b/app/cdash/app/Model/BuildConfigure.php
@@ -32,6 +32,7 @@ class BuildConfigure
     public $BuildId;
     public $NumberOfWarnings;
     public $NumberOfErrors;
+    public $LabelCollection;
     private $Crc32;
 
     private $PDO;

diff --git a/app/cdash/app/Model/BuildErrorFilter.php b/app/cdash/app/Model/BuildErrorFilter.php
@@ -21,8 +21,8 @@ class BuildErrorFilter
 {
     private $ErrorsFilter;
     private $WarningsFilter;
-
     public $Project;
+    private $PDO;
 
     public function __construct(Project $project)
     {

diff --git a/app/cdash/tests/test_buildgetdate.php b/app/cdash/tests/test_buildgetdate.php
@@ -46,7 +46,6 @@ public function testBuildGetDate()
         $build->StartTime = $evening_after;
 
         $expected_date = '2009-02-24';
-        $build->NightlyStartTime = false;
         $date = $build->GetDate();
         if ($date !== $expected_date) {
             $this->fail("Evening case: expected $expected_date, found $date");
@@ -56,15 +55,13 @@ public function testBuildGetDate()
         $build->GetProject()->SetNightlyTime('09:00:00 America/New_York');
         $build->StartTime = $morning_before;
         $expected_date = '2009-02-22';
-        $build->NightlyStartTime = false;
         $date = $build->GetDate();
         if ($date !== $expected_date) {
             $this->fail("Morning case: expected $expected_date, found $date");
         }
 
         $build->StartTime = $morning_after;
         $expected_date = '2009-02-23';
-        $build->NightlyStartTime= false;
         $date = $build->GetDate();
         if ($date !== $expected_date) {
             $this->fail("Morning case: expected $expected_date, found $date");

diff --git a/app/cdash/xml_handlers/done_handler.php b/app/cdash/xml_handlers/done_handler.php
@@ -26,6 +26,7 @@ class DoneHandler extends AbstractHandler
     private $FinalAttempt;
     private $PendingSubmissions;
     private $Requeue;
+    public $backupFileName;
 
     public function __construct($projectID)
     {

diff --git a/app/cdash/xml_handlers/testing_handler.php b/app/cdash/xml_handlers/testing_handler.php
@@ -37,6 +37,9 @@ class TestingHandler extends AbstractHandler implements ActionableBuildInterface
     private $TestMeasurement;
     private $Label;
 
+    // TODO: Evaluate whether this is needed
+    private $Labels;
+
     private $TestCreator;
 
     /** @var Build[] Builds */

diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -6774,11 +6774,6 @@ parameters:
 			count: 1
 			path: app/cdash/app/Model/Build.php
 
-		-
-			message: "#^Access to an undefined property CDash\\\\Model\\\\BuildConfigure\\:\\:\\$LabelCollection\\.$#"
-			count: 5
-			path: app/cdash/app/Model/BuildConfigure.php
-
 		-
 			message: """
 				#^Call to deprecated function add_log\\(\\)\\:
@@ -6881,6 +6876,11 @@ parameters:
 			count: 1
 			path: app/cdash/app/Model/BuildConfigure.php
 
+		-
+			message: "#^Property CDash\\\\Model\\\\BuildConfigure\\:\\:\\$LabelCollection has no type specified\\.$#"
+			count: 1
+			path: app/cdash/app/Model/BuildConfigure.php
+
 		-
 			message: "#^Property CDash\\\\Model\\\\BuildConfigure\\:\\:\\$Log has no type specified\\.$#"
 			count: 1
@@ -7153,11 +7153,6 @@ parameters:
 			count: 1
 			path: app/cdash/app/Model/BuildError.php
 
-		-
-			message: "#^Access to an undefined property CDash\\\\Model\\\\BuildErrorFilter\\:\\:\\$PDO\\.$#"
-			count: 8
-			path: app/cdash/app/Model/BuildErrorFilter.php
-
 		-
 			message: "#^Argument of an invalid type array\\<int, string\\>\\|false supplied for foreach, only iterables are supported\\.$#"
 			count: 1
@@ -7258,6 +7253,11 @@ parameters:
 			count: 1
 			path: app/cdash/app/Model/BuildErrorFilter.php
 
+		-
+			message: "#^Property CDash\\\\Model\\\\BuildErrorFilter\\:\\:\\$PDO has no type specified\\.$#"
+			count: 1
+			path: app/cdash/app/Model/BuildErrorFilter.php
+
 		-
 			message: "#^Property CDash\\\\Model\\\\BuildErrorFilter\\:\\:\\$Project has no type specified\\.$#"
 			count: 1
@@ -21139,11 +21139,6 @@ parameters:
 			count: 1
 			path: app/cdash/tests/test_buildfailuredetails.php
 
-		-
-			message: "#^Access to an undefined property CDash\\\\Model\\\\Build\\:\\:\\$NightlyStartTime\\.$#"
-			count: 1
-			path: app/cdash/tests/test_buildgetdate.php
-
 		-
 			message: "#^Method BuildGetDateTestCase\\:\\:testBuildGetDate\\(\\) has no return type specified\\.$#"
 			count: 1
@@ -27877,6 +27872,11 @@ parameters:
 			count: 1
 			path: app/cdash/xml_handlers/done_handler.php
 
+		-
+			message: "#^Property DoneHandler\\:\\:\\$backupFileName has no type specified\\.$#"
+			count: 1
+			path: app/cdash/xml_handlers/done_handler.php
+
 		-
 			message: "#^Access to an undefined property DynamicAnalysisHandler\\:\\:\\$BuildName\\.$#"
 			count: 5
@@ -28593,11 +28593,6 @@ parameters:
 			count: 1
 			path: app/cdash/xml_handlers/stack.php
 
-		-
-			message: "#^Access to an undefined property TestingHandler\\:\\:\\$Labels\\.$#"
-			count: 3
-			path: app/cdash/xml_handlers/testing_handler.php
-
 		-
 			message: "#^Call to an undefined method CDash\\\\Messaging\\\\Preferences\\\\NotificationPreferencesInterface\\:\\:get\\(\\)\\.$#"
 			count: 1
@@ -28733,6 +28728,11 @@ parameters:
 			count: 1
 			path: app/cdash/xml_handlers/testing_handler.php
 
+		-
+			message: "#^Property TestingHandler\\:\\:\\$Labels has no type specified\\.$#"
+			count: 1
+			path: app/cdash/xml_handlers/testing_handler.php
+
 		-
 			message: "#^Property TestingHandler\\:\\:\\$NumberTestsFailed has no type specified\\.$#"
 			count: 1