Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(router/atc): unify expression validation function in schema #12878

Merged
merged 5 commits into from
Jun 4, 2024
Merged

refactor(router/atc): unify expression validation function in schema #12878

merged 5 commits into from
Jun 4, 2024

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Apr 18, 2024 •
edited
Loading

Summary

Simplify the code, moving some logic into transform.lua.

KAG-4138

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added core/router core/db schema-change-noteworthy cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Apr 18, 2024
@chronolaw chronolaw marked this pull request as ready for review April 18, 2024 08:19
@pull-request-size pull-request-size bot added size/L and removed size/M labels Apr 18, 2024
@chronolaw chronolaw force-pushed the refactor/rename_amending_expression branch from 4f65ef6 to 66bb363 Compare April 18, 2024 10:00
@chronolaw chronolaw force-pushed the refactor/rename_amending_expression branch 2 times, most recently from b5a84be to 551ca7d Compare May 15, 2024 00:18
@chronolaw chronolaw force-pushed the refactor/rename_amending_expression branch from 551ca7d to 28e4479 Compare May 23, 2024 01:57
@chronolaw chronolaw force-pushed the refactor/rename_amending_expression branch from 28e4479 to 049deef Compare May 29, 2024 06:26
@chronolaw chronolaw requested review from ADD-SP and chobits June 3, 2024 05:59
@ADD-SP ADD-SP merged commit 16fe25e into master Jun 4, 2024
27 checks passed
@ADD-SP ADD-SP deleted the refactor/rename_amending_expression branch June 4, 2024 08:16
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chobits chobits chobits approved these changes

@Water-Melon Water-Melon Water-Melon approved these changes

@ADD-SP ADD-SP ADD-SP approved these changes

Assignees

@chronolaw chronolaw

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/db core/router schema-change-noteworthy size/L skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chronolaw @team-gateway-bot @chobits @Water-Melon @ADD-SP