Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(dynamic-hooks): add dynamic hooks documentation #13068

Merged
merged 1 commit into from
May 28, 2024
Merged

docs(dynamic-hooks): add dynamic hooks documentation #13068

merged 1 commit into from
May 28, 2024

Conversation

samugi
Copy link
Member

@samugi samugi commented May 23, 2024 •
edited
Loading

Summary

Adds a readme for the dynamic hooks core feature and reference docs in the code

Checklist

  • (no) The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • (no) There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

KAG-4552

@samugi samugi marked this pull request as draft May 23, 2024 13:01
@github-actions github-actions bot added core/docs cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels May 23, 2024
ADD-SP
ADD-SP reviewed May 27, 2024
View reviewed changes
Copy link
Contributor

@ADD-SP ADD-SP left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd better to claim that this is an internal-only feature, and use it at your own risk.

Since it might be considered as a public feature by customers once we provide a document for that.

@samugi samugi force-pushed the docs/dynamic-hooks branch 2 times, most recently from 74d7f96 to 5c058a7 Compare May 27, 2024 10:30
@samugi
docs(dynamic-hooks): add dynamic hooks docs
638dbb7 
adds a readme for the dynamic hooks core feature
and reference docs in the code
@samugi samugi marked this pull request as ready for review May 27, 2024 10:31
@samugi samugi requested review from hanshuebner and ADD-SP May 27, 2024 10:31
@hanshuebner hanshuebner merged commit d73a835 into master May 28, 2024
31 of 32 checks passed
@hanshuebner hanshuebner deleted the docs/dynamic-hooks branch May 28, 2024 06:40
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanshuebner hanshuebner hanshuebner approved these changes

@windmgc windmgc windmgc approved these changes

@ADD-SP ADD-SP ADD-SP approved these changes

Assignees

@samugi samugi

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/docs size/L skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@samugi @team-gateway-bot @hanshuebner @windmgc @ADD-SP