Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): generate the Docker tag latest-ubuntu only for the latest commit on the default branch #13096

Merged
merged 1 commit into from
Jun 5, 2024
Merged

chore(ci): generate the Docker tag latest-ubuntu only for the latest commit on the default branch #13096

merged 1 commit into from
Jun 5, 2024

Conversation

Water-Melon
Copy link
Contributor

@Water-Melon Water-Melon commented May 28, 2024 •
edited
Loading

Summary

  • Stop generating the latest-ubuntu image on non-default branches.
  • Rerunning the old commit action on the default branch will not generate latest-ubuntu.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

KAG-4374

@github-actions github-actions bot added the chore Not part of the core functionality of kong, but still needed label May 28, 2024
@Water-Melon Water-Melon force-pushed the kag4374 branch 3 times, most recently from fc54fa7 to e05ad24 Compare May 28, 2024 09:49
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Jun 3, 2024
@Water-Melon Water-Melon force-pushed the kag4374 branch 8 times, most recently from 0fed756 to 8270659 Compare June 3, 2024 09:40
@Water-Melon
Copy link
Contributor Author

Here are two jobs:
the first test commit job: https://github.com/Kong/kong/actions/runs/9347881316?pr=13096
the second one: https://github.com/Kong/kong/actions/runs/9347980953/job/25726205376?pr=13096

After the second commit ran, the image digest was 12733da692fc. Then, rerun the job for the first commit. After running, the digest for latest-ubuntu is still 12733da692fc, while the digest for pr-13096-ubuntu is 6241306a875e.

@pull-request-size pull-request-size bot added size/XS and removed size/S labels Jun 3, 2024
@Water-Melon Water-Melon force-pushed the kag4374 branch 2 times, most recently from 665d07e to 7781cf4 Compare June 3, 2024 10:14
@ADD-SP ADD-SP added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Jun 4, 2024
@Water-Melon Water-Melon changed the title chore(ci): stop generating the latest-ubuntu image on non-default branches chore(ci): generate latest-ubuntu only on new default branch commit Jun 4, 2024
@Water-Melon Water-Melon changed the title chore(ci): generate latest-ubuntu only on new default branch commit chore(ci): generate the Docker tag latest-ubuntu only for the latest commit on the default branch Jun 4, 2024
@ADD-SP ADD-SP merged commit b088118 into master Jun 5, 2024
14 checks passed
@ADD-SP ADD-SP deleted the kag4374 branch June 5, 2024 01:19
@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Jun 5, 2024
@kikito kikito removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Jun 11, 2024
@Kong Kong deleted a comment from team-gateway-bot Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bungle bungle bungle approved these changes

@AndyZhang0707 AndyZhang0707 AndyZhang0707 approved these changes

@ADD-SP ADD-SP ADD-SP approved these changes

Assignees

@Water-Melon Water-Melon

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee chore Not part of the core functionality of kong, but still needed size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Water-Melon @bungle @AndyZhang0707 @ADD-SP @kikito