Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport -> release/3.7.x] feat(db/schema): do not allow setting priority with traditional route in mixed mode #13100

Closed
wants to merge 1 commit into from
Closed

[backport -> release/3.7.x] feat(db/schema): do not allow setting priority with traditional route in mixed mode #13100

wants to merge 1 commit into from

Conversation

team-gateway-bot
Copy link
Collaborator

Automated backport to release/3.7.x, triggered by a label in #13021.

Original description

Summary

Notice: regex_priority and priority have the default value 0, so we think 0 is equivalent to "not set".

KAG-4411

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@chronolaw @github-actions
fix(db/schema): do not allow setting priority with traditional ro…
182a5ec 
…ute in mixed mode (#13021)

`priority` has no meaning for traditional based routes, this PR adds additional validation check
to make sure these are detected at creation time to avoid causing confusions to the user.

KAG-4411

(cherry picked from commit d286b1c)
@team-gateway-bot team-gateway-bot added cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/db schema-change-noteworthy size/M labels May 28, 2024
@team-gateway-bot team-gateway-bot mentioned this pull request May 28, 2024
Merged
3 tasks
@chronolaw
Copy link
Contributor

Close for further decision.

@chronolaw chronolaw closed this May 29, 2024
@chronolaw chronolaw deleted the backport-13021-to-release/3.7.x branch May 29, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chronolaw chronolaw chronolaw approved these changes

Assignees

@chronolaw chronolaw

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/db schema-change-noteworthy size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@team-gateway-bot @chronolaw