Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(dns): fix individual_toip test failure due to cache hits #13114

Merged
merged 2 commits into from
May 31, 2024
Merged

tests(dns): fix individual_toip test failure due to cache hits #13114

merged 2 commits into from
May 31, 2024

Conversation

chobits
Copy link
Contributor

@chobits chobits commented May 30, 2024 •
edited by jira bot
Loading

Summary

  1. used empty search option to avoid generating extra query for search domains
  2. introduced some delays in the queries of background coroutines to avoid cache hits

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix KAG-4520

@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label May 30, 2024
@chobits chobits force-pushed the chore/flaky-individual_toip branch from 4d0175d to 3a3cc0f Compare May 30, 2024 09:19
@ADD-SP ADD-SP merged commit 9641d9b into master May 31, 2024
24 checks passed
@ADD-SP ADD-SP deleted the chore/flaky-individual_toip branch May 31, 2024 08:16
@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label May 31, 2024
@kikito kikito removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Jun 4, 2024
@Kong Kong deleted a comment from team-gateway-bot Jun 4, 2024
locao pushed a commit that referenced this pull request Jun 21, 2024
@chobits @AndyZhang0707
tests(dns): fix individual_toip test failure due to cache hits (#13114)
7f502fb 
* used empty search option to avoid generating extra query for search domains
* introduced some delays in the queries of background coroutines to avoid cache hits

KAG-4520
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chronolaw chronolaw chronolaw approved these changes

@liverpool8056 liverpool8056 liverpool8056 approved these changes

Assignees

@chobits chobits

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/S skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chobits @chronolaw @liverpool8056 @kikito @ADD-SP