-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests(ci): copy and upload failed test logs #13115
Conversation
5bb4ae9
to
c13fe4b
Compare
08d0f4c
to
ca19571
Compare
9b711be
to
9ef7c93
Compare
It's been fixed. |
Thanks @dndx. That was because I encapsulated the logic for copying errlog into a function before opening the PR, but the level for Here is the test: |
ab53aab
to
728b10e
Compare
a28d4d3
to
08dbd0d
Compare
Here is the newest test ci: https://github.com/Kong/kong/actions/runs/9462602728/job/26065965800?pr=13115 We can see that the first test outputs a red 'Failed to save...' message because there is no error log. The second test outputs a yellow 'Log saved as...' message because an error log is present. |
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13115-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13115-to-master-to-upstream
git checkout -b cherry-pick-13115-to-master-to-upstream
ancref=$(git merge-base 49f7b44c8ef5f9db1c9c62701a79437dfc116c16 1aa82a04bc8f3b8b94b5f4d0c0fefed7a27a530d)
git cherry-pick -x $ancref..1aa82a04bc8f3b8b94b5f4d0c0fefed7a27a530d |
KAG-2563
Summary
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]