Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(ci): copy and upload failed test logs #13115

Merged
merged 1 commit into from
Jun 12, 2024
Merged

tests(ci): copy and upload failed test logs #13115

merged 1 commit into from
Jun 12, 2024

Conversation

Water-Melon
Copy link
Contributor

KAG-2563

Summary

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added chore Not part of the core functionality of kong, but still needed cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels May 30, 2024
@Water-Melon Water-Melon force-pushed the kag2563 branch 15 times, most recently from 5bb4ae9 to c13fe4b Compare May 31, 2024 10:38
@pull-request-size pull-request-size bot added size/L and removed size/M labels May 31, 2024
@Water-Melon Water-Melon force-pushed the kag2563 branch 2 times, most recently from 08d0f4c to ca19571 Compare May 31, 2024 10:50
@pull-request-size pull-request-size bot added size/M and removed size/L labels May 31, 2024
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jun 1, 2024
@Water-Melon Water-Melon force-pushed the kag2563 branch 3 times, most recently from 9b711be to 9ef7c93 Compare June 7, 2024 03:34
@Water-Melon
Copy link
Contributor Author

Could you resolve merge conflicts?

It's been fixed.

@Water-Melon
Copy link
Contributor Author

Water-Melon commented Jun 7, 2024

I downloaded the file from https://github.com/Kong/kong/actions/runs/9343590417?pr=13115, the filename is a bit hard to understand:

...zel-bin_build_kong-dev_share_lua_5.1_luassert_assert.lua.43.log

Can we consider change the filename to something like:

spec/02-integration/06-invalidations/02-core_entities_invalidations_spec_line_109.log

or

spec_02-integration_06-invalidations_02-core_entities_invalidations_spec_line_109.log

instead? It will be much easier to search for.

Thanks @dndx. That was because I encapsulated the logic for copying errlog into a function before opening the PR, but the level for debug.getinfo was not updated accordingly. This problem has been fixed, and I also adjusted the name suffix.

Here is the test:
https://github.com/Kong/kong/actions/runs/9411253941/job/25924210228?pr=13115#step:20:42
https://github.com/Kong/kong/actions/runs/9462602728/job/26065965800?pr=13115

@pull-request-size pull-request-size bot added size/M and removed size/L labels Jun 7, 2024
@Water-Melon Water-Melon force-pushed the kag2563 branch 3 times, most recently from ab53aab to 728b10e Compare June 7, 2024 04:12
@Water-Melon Water-Melon marked this pull request as ready for review June 7, 2024 04:12
@Water-Melon Water-Melon force-pushed the kag2563 branch 2 times, most recently from a28d4d3 to 08dbd0d Compare June 7, 2024 09:41
spec/helpers.lua Outdated Show resolved Hide resolved
@Water-Melon
Copy link
Contributor Author

Here is the newest test ci: https://github.com/Kong/kong/actions/runs/9462602728/job/26065965800?pr=13115

We can see that the first test outputs a red 'Failed to save...' message because there is no error log. The second test outputs a yellow 'Log saved as...' message because an error log is present.

@pull-request-size pull-request-size bot added size/M and removed size/L labels Jun 11, 2024
@ADD-SP ADD-SP merged commit e431bb2 into master Jun 12, 2024
30 checks passed
@ADD-SP ADD-SP deleted the kag2563 branch June 12, 2024 02:42
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13115-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13115-to-master-to-upstream
git checkout -b cherry-pick-13115-to-master-to-upstream
ancref=$(git merge-base 49f7b44c8ef5f9db1c9c62701a79437dfc116c16 1aa82a04bc8f3b8b94b5f4d0c0fefed7a27a530d)
git cherry-pick -x $ancref..1aa82a04bc8f3b8b94b5f4d0c0fefed7a27a530d

@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Jun 12, 2024
@AndyZhang0707 AndyZhang0707 removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee chore Not part of the core functionality of kong, but still needed size/M skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants