Forward Dokka Generator messages to Gradle logger #3833
+342
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-enko
force-pushed
the
adam/feat/KT-70336/log-dokka-generator-messages
branch
from
7d5cf5b
to
5bfc667
Compare
adam-enko
added
the
runner: Gradle plugin
whyoleg
approved these changes
Oct 2, 2024
| .build { | ||
| output.invariantNewlines() shouldContain """ | ||
| > Task :dokkaGenerateModuleHtml | ||
| e: [:dokkaGenerateModuleHtml] test error message |
There was a problem hiding this comment.
TBH, I don't think that duplicating task name will be useful, but I'm not against having it :)
There was a problem hiding this comment.
I put the task name in because it can be confusing if there are multiple generations at the same time, or if running with --quiet. It's already a bit confusing when aggregating, because sometimes the same error is shown for both module and publication generation. But we can revisit the message if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Dokka Gradle tasks to forward DokkaGenerator logs to the appropriate levels.
KT-71719