Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add READMEs to examples #119

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

wldeh
Copy link
Contributor

@wldeh wldeh commented Jun 27, 2023

Addresses #96

This pull request introduces README files to each example subdirectory and the root examples directory. These README files serve as a guide to help both new and experienced users navigate and understand the structure and use of each example. The goal here is to improve the user experience by providing helpful and clear information about each example, making it easier for developers to get started with or dive deeper into the kotlinx-benchmark library.

Please review and let me know if there are any suggestions or improvements. Thanks!

Copy link
Collaborator

@qurbonzoda qurbonzoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems a great opportunity to improve description of tasks the plugin creates.

examples/README.md Outdated Show resolved Hide resolved
examples/README.md Outdated Show resolved Hide resolved
examples/java/README.md Outdated Show resolved Hide resolved
examples/java/README.md Outdated Show resolved Hide resolved
examples/java/README.md Outdated Show resolved Hide resolved
examples/java/README.md Outdated Show resolved Hide resolved
| --- | --- |
| `gradle assembleBenchmarks` | Generate and build all benchmarks in the project |
| `gradle benchmark` | Execute all benchmarks in the project |
| `gradle mainBenchmark` | Execute benchmark for 'benchmarks' |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 'main' in this example project.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pointing this out and for your feedback.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment doesn't seem to be resolved.
Should be something like Runs benchmarks for 'main' benchmark target.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies, I believe I resolved it and lost my changes without saving. Will address

@wldeh wldeh changed the base branch from master to improve-documentation July 6, 2023 06:50
@qurbonzoda qurbonzoda merged commit e1d7432 into Kotlin:improve-documentation Jul 7, 2023
OndrejSliva pushed a commit to OndrejSliva/kotlinx-benchmark that referenced this pull request Jan 10, 2024
…e.maven.plugins-maven-resources-plugin-3.3.1

build(deps): bump maven-resources-plugin from 3.3.0 to 3.3.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants