Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infra enhancements #206

Merged
merged 3 commits into from
Sep 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,12 @@ A clear and concise description of what the bug is.

**To Reproduce**
Steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
1. Kotlin version
2. Gradle version
3. OS (Or at least KMP platform)
4. Minimal reproducer in code
5. Error description
6. And so on

**Expected behavior**
A clear and concise description of what you expected to happen.
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name: Feature request
about: Suggest an idea for this project
title: ''
labels: enhancement
labels: feature
assignees: Mr3zee

---
Expand Down
2 changes: 2 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,5 @@ Describe what problem this PR solves and why it is important. Refer to a bug/tic
**Solution**
Describe your solution.

**ATTENTION**
Provide this pull request with proper labels, it is important to simplify generation of releases.
26 changes: 26 additions & 0 deletions .github/release.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
changelog:
exclude:
authors:
- renovate[bot]
categories:
- title: Features 🎉
labels:
- feature
- title: Breaking Changes 🔴
labels:
- breaking
- title: Deprecations ⚠️
labels:
- deprecation
- title: Bug fixes 🐛
labels:
- bug
- title: Documentation 📗
labels:
- docs
- title: Infra 🚧
labels:
- infra
- title: Other Changes 🧹
labels:
- "*"
24 changes: 24 additions & 0 deletions .github/workflows/labels.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
name: Check PR Labels

on:
pull_request:
types:
- opened
- synchronize
- reopened
- labeled
- unlabeled
- converted_to_draft
- ready_for_review

jobs:
check-labels:
name: Check labels
runs-on: ubuntu-latest
if: ${{ github.event.pull_request.draft == false && !contains(github.event.pull_request.labels.*.name, 'feature') && !contains(github.event.pull_request.labels.*.name, 'bug') && !contains(github.event.pull_request.labels.*.name, 'breaking') && !contains(github.event.pull_request.labels.*.name, 'infra') && !contains(github.event.pull_request.labels.*.name, 'docs') && !contains(github.event.pull_request.labels.*.name, 'deprecation') && !contains(github.event.pull_request.labels.*.name, 'dependencies') }}
steps:
- name: Fail build after no labels present
run: |
echo "Pull request does not contain any required labels"
echo "Please use at least one of 'feature', 'bug', 'breaking', 'infra', 'docs', 'deprecation' or 'dependencies' labels"
exit 1
1 change: 1 addition & 0 deletions compiler-plugin/gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

import util.*

val isGradlePlugin = project.properties["kotlinx.rpc.gradle.plugin"] == "true"
val isGradlePlugin = project.name == "gradle-plugin"
val publishingExtension = project.extensions.findByType<PublishingExtension>()
val globalRootDir: String by extra

Expand Down
5 changes: 0 additions & 5 deletions gradle-plugin/gradle.properties

This file was deleted.

1 change: 1 addition & 0 deletions gradle-plugin/gradle.properties
1 change: 1 addition & 0 deletions ksp-plugin/gradle.properties
1 change: 1 addition & 0 deletions tests/compiler-plugin-tests/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ dependencies {
testImplementation(libs.junit5.platform.runner)
testImplementation(libs.junit5.platform.suite.api)

testDataClasspath(projects.utils)
testDataClasspath(libs.coroutines.core)
testDataClasspath(libs.serialization.core)
}
Expand Down