Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include runBlocking() in context and dispatchers tutorial code #3674

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

toboche
Copy link

@toboche toboche commented Mar 12, 2023

The texts in the "Dispatchers and threads" and "Unconfined vs confined dispatcher" sections explicitly mention the example code having runBlocking call somewhere but the sample code does not show the call. Because of that the reader hass to assume (or check the source code) where the runBlocking call happens.

I'd propose to include the call to runBlocking in the code samples, so that the readers don't have to guess where the actual runBlocking call is done.

Include `runBlocking` in the "Dispatchers and threads" and "Unconfined vs confined dispatcher" code examples as `runBlocking` mentioned explicitly in these sections' texts.
@toboche toboche changed the title Include runBlocking{} in the context sample code Include runBlocking{} in context and dispatchers tutorial code Mar 13, 2023
@toboche toboche changed the title Include runBlocking{} in context and dispatchers tutorial code Include runBlocking() in context and dispatchers tutorial code Mar 13, 2023
@toboche toboche changed the base branch from master to develop March 13, 2023 09:48
@toboche toboche changed the base branch from develop to master March 15, 2023 17:58
Copy link
Collaborator

@dkhalanskyjb dkhalanskyjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, this makes sense. There's also the snippet with val a = async that mentions runBlocking but doesn't include one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants