Do not report exceptions raised in CoroutineDispatcher.dispatch as in… #4181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkhalanskyjb
requested changes
Aug 12, 2024
There was a problem hiding this comment.
This is a nice start, though a review of the other places where dispatch, isDispatchNeeded, and/or intercepted() happens shows that it's in general very easy to leave kotlinx-coroutines in an incorrect state if dispatchers throw: #4209
If you're up for it, we can try to provide sensible behavior for dispatcher errors in all places as part of this pull request, or we can limit the scope to that one specific crash and leave the more robust and general solution for another time.
kotlinx-coroutines-core/common/src/internal/DispatchedContinuation.kt
Outdated
Show resolved
Hide resolved
…h as internal errors Prevent reporting DispatchException itself
…h as internal errors Fix test: add new exception to the list of known exceptions
zuevmaxim
force-pushed
the
zuev/fix-4091
branch
from
33d85f4
to
7d0cbc4
Compare
|
Historical note: we've discussed it internally and decided that #4209 is out of this PR's scope. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ternal errors
Fix #4091