ThreadContextElement for common #4208
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukellmann
reviewed
Aug 13, 2024
| @Suppress("IMPLICIT_BOXING_IN_IDENTITY_EQUALS") | ||
| return when { | ||
| countOrElement === 0 -> NO_THREAD_ELEMENTS // very fast path when there are no active ThreadContextElements | ||
| // ^^^ identity comparison for speed, we know zero always has the same identity |
There was a problem hiding this comment.
Is this true for non JVM platforms? The code seems correct either way but the comment might be updated if this is platform dependent.
| } | ||
|
|
||
| // Counts ThreadContextElements in the context | ||
| // Any? here is Int | ThreadContextElement (when count is one) |
There was a problem hiding this comment.
Why isn't Any used instead of Any?? Then threadContextElements wouldn't have to use !!.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3326
Uses #4174 as a reference