Implementation of correlated noise #151
Open
+433
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckermr
reviewed
Jul 12, 2021
beckermr
reviewed
Jul 12, 2021
beckermr
reviewed
Jul 13, 2021
beckermr
reviewed
Sep 22, 2021
descwl_shear_sims/sim.py
Outdated
| @@ -221,6 +233,10 @@ def make_exp( | |||
| star_bleeds=False, | |||
| sky_n_sigma=None, | |||
| draw_method='auto', | |||
| galsim_rng=None, | |||
There was a problem hiding this comment.
We do not need this keyword. This is generated internally.
There was a problem hiding this comment.
You right, I forgot to remove the keyword. It should not be used in the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few changements to implement correlated noise.
The way it is done, the original test should not be affected.
I have created a new pytest
test_shear_meas_corr_noise.pywhere the correlated noise is ON by default (this can probably be adjusted).As we discuss with @beckermr the flux of the galaxies has to be change in order to see any effect of this. It is not included in this pull request since I did not find a way to do it without hard coded something, yet.