Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor twopoint #451

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Refactor twopoint #451

wants to merge 24 commits into from

Conversation

marcpaterno
Copy link
Collaborator

This PR will refactor the statistic class TwoPoint to introduce a instance variable TwoPointModel, with the TwoPointModel handling everything to do with theory calculations.

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.6%. Comparing base (1ec56d9) to head (af87f6b).

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #451   +/-   ##
======================================
  Coverage    98.6%   98.6%           
======================================
  Files          52      53    +1     
  Lines        3888    3905   +17     
======================================
+ Hits         3834    3851   +17     
  Misses         54      54           
Files with missing lines Coverage Δ
firecrown/generators/two_point.py 100.0% <100.0%> (ø)
firecrown/likelihood/source_factories.py 100.0% <100.0%> (ø)
firecrown/likelihood/two_point.py 98.4% <100.0%> (-0.4%) ⬇️
firecrown/utils.py 100.0% <100.0%> (ø)

@marcpaterno marcpaterno marked this pull request as ready for review September 27, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants