Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependency io.nlopez.compose.rules:ktlint to v0.3.13 #4169

Merged
merged 2 commits into from
Apr 1, 2024
Merged

Update dependency io.nlopez.compose.rules:ktlint to v0.3.13 #4169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a697e39
Update dependency io.nlopez.compose.rules:ktlint to v0.3.13
renovate[bot] Apr 1, 2024
e41463a
TODO
Goooler Apr 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,7 @@ spotless {
kotlin {
target("lawnchair/src/**/*.kt")
ktlint().customRuleSets([
"io.nlopez.compose.rules:ktlint:0.3.12",
"io.nlopez.compose.rules:ktlint:0.3.13",
]).editorConfigOverride([
"ktlint_compose_modifier-missing-check": "disabled",
"ktlint_compose_compositionlocal-allowlist": "disabled",
Expand Down
2 changes: 1 addition & 1 deletion lawnchair/src/app/lawnchair/ui/placeholder/Placeholder.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ object PlaceholderDefaults {
* on/off screen. The boolean parameter defined for the transition is [visible].
*/
// TODO: need to migrate to Modifier.Node, see https://mrmans0n.github.io/compose-rules/rules/#avoid-modifier-extension-factory-functions
@Suppress("ktlint:compose:modifier-composable-check")
@Suppress("ktlint:compose:modifier-composable-check", "ktlint:compose:modifier-composed-check")
@Composable
fun Modifier.placeholder(
visible: Boolean,
Expand Down
2 changes: 2 additions & 0 deletions lawnchair/src/app/lawnchair/util/Padding.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ import androidx.compose.ui.unit.LayoutDirection
import androidx.compose.ui.unit.dp
import androidx.compose.ui.unit.max

// TODO: https://mrmans0n.github.io/compose-rules/rules/#avoid-modifier-extension-factory-functions
@Suppress("ktlint:compose:modifier-composed-check")
fun Modifier.navigationBarsOrDisplayCutoutPadding(): Modifier = composed {
val sides = WindowInsetsSides.Horizontal + WindowInsetsSides.Bottom
val navigationBars = WindowInsets.navigationBars.only(sides).asPaddingValues()
Expand Down
2 changes: 2 additions & 0 deletions lawnchair/src/app/lawnchair/util/SmartBorder.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ fun Modifier.smartBorder(border: BorderStroke, shape: Shape = RectangleShape) =
fun Modifier.smartBorder(width: Dp, color: Color, shape: Shape = RectangleShape) =
smartBorder(width, SolidColor(color), shape)

// TODO: https://mrmans0n.github.io/compose-rules/rules/#avoid-modifier-extension-factory-functions
@Suppress("ktlint:compose:modifier-composed-check")
fun Modifier.smartBorder(
width: Dp,
brush: Brush,
Expand Down