Add hexagon icon shape #4697
Merged
Add hexagon icon shape #4697
+56
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not a big deal, but currently, all icon shapes are listed in the UI alphabetically (except for System at the very top). Slotting Hexagon between Octagon and One UI would break this trend. |
validcube
reviewed
Aug 22, 2024
I saw the order is hard-coded, so even if for English it may work like that, for other languages it won't, isn't it? But yeah, I changed the order so it fits the current scheme. |
MrSluffy
approved these changes
Aug 23, 2024
SuperDragonXD
approved these changes
Aug 23, 2024
nulldrf
pushed a commit
to nulldrf/lawnchair
that referenced
this pull request
Aug 24, 2024
* Add hexagon icon shape * Fix formatting * Change shape order in settings * Remove polish translation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new icon shape - hexagon. Basically this is port of my own PR for NeoApplications/Neo-Launcher#388
From my tests, it works well:
Type of change
❌ General change (non-breaking change that doesn't fit the below categories like copyediting)
❌ Bug fix (non-breaking change which fixes an issue)
✅ New feature (non-breaking change which adds functionality)
❌ Breaking change (fix or feature that would cause existing functionality to not work as expected)