Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Live Information (Announcements) #4722

Merged
merged 16 commits into from
Sep 14, 2024
Merged

Conversation

yasanglass
Copy link
Member

Description

Multiple improvements for Announcements (Live Information) feature:

  • The announcement dismissals are now persistent
  • The ability to set custom icon for each announcement
  • The ability to set custom channel target for each announcement
  • The unknown keys will now be ignored when decoding

Type of change

❌ General change (non-breaking change that doesn't fit the below categories like copyediting)
❌ Bug fix (non-breaking change which fixes an issue)
✅ New feature (non-breaking change which adds functionality)
❌ Breaking change (fix or feature that would cause existing functionality to not work as expected)

@yasanglass
Copy link
Member Author

yasanglass commented Sep 12, 2024

Not sure why I kept it as draft before, I went through the code now and it looks to be complete.

Let me know if anything does not work as expected or if I should add more features to Live Information.

@yasanglass yasanglass changed the title Improve announcements Improve Live Information (Announcements) Sep 12, 2024
Copy link
Collaborator

@SuperDragonXD SuperDragonXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be fine, however an option to clear the list of dismissed announcements (alongside other announcement-related settings) could be helpful for testing. You could put this in the debug menu.

@yasanglass
Copy link
Member Author

Seems to be fine, however an option to clear the list of dismissed announcements (alongside other announcement-related settings) could be helpful for testing. You could put this in the debug menu.

I added a button to the debug menu that fully resets local Live Information

@yasanglass yasanglass enabled auto-merge (squash) September 14, 2024 07:38
@yasanglass yasanglass merged commit c1108ae into 14-dev Sep 14, 2024
3 checks passed
@yasanglass yasanglass deleted the improve-announcements branch September 14, 2024 09:29
nulldrf pushed a commit to nulldrf/lawnchair that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants