-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Live Information (Announcements) #4722
Conversation
c9ca83a
to
b026902
Compare
d4d80cf
to
8b07e0c
Compare
Not sure why I kept it as draft before, I went through the code now and it looks to be complete. Let me know if anything does not work as expected or if I should add more features to Live Information. |
lawnchair/src/app/lawnchair/ui/preferences/components/AnnouncementPreference.kt
Outdated
Show resolved
Hide resolved
a18fed8
to
c49b7e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be fine, however an option to clear the list of dismissed announcements (alongside other announcement-related settings) could be helpful for testing. You could put this in the debug menu.
8fa977c
to
39cd958
Compare
I added a button to the debug menu that fully resets local Live Information |
Description
Multiple improvements for Announcements (Live Information) feature:
Type of change
❌ General change (non-breaking change that doesn't fit the below categories like copyediting)
❌ Bug fix (non-breaking change which fixes an issue)
✅ New feature (non-breaking change which adds functionality)
❌ Breaking change (fix or feature that would cause existing functionality to not work as expected)