Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: AllocationManager Storage Simplification #787

Merged
merged 8 commits into from
Oct 1, 2024

Conversation

ypatil12
Copy link
Collaborator

@ypatil12 ypatil12 commented Oct 1, 2024

  • Takes advantage of only 1 alloc/dealloc at at time to simplify storage

src/contracts/core/AllocationManager.sol Outdated Show resolved Hide resolved
src/contracts/core/AllocationManager.sol Outdated Show resolved Hide resolved
src/contracts/core/AllocationManager.sol Outdated Show resolved Hide resolved
src/contracts/core/AllocationManager.sol Outdated Show resolved Hide resolved
src/contracts/core/AllocationManager.sol Outdated Show resolved Hide resolved
src/contracts/core/AllocationManager.sol Outdated Show resolved Hide resolved
src/contracts/core/AllocationManager.sol Outdated Show resolved Hide resolved
@0xClandestine 0xClandestine merged commit 9d131b1 into slashing-magnitudes Oct 1, 2024
5 of 12 checks passed
@0xClandestine 0xClandestine deleted the feat/am-cleanup-2 branch October 1, 2024 18:22
wadealexc added a commit that referenced this pull request Oct 3, 2024
* chore: pending delay calc cleanup

* chore: storage pointer cleanup

* eigenpods slashing updates (#745)

* update checkpoint struct

* feat: AllocationManager Storage Simplification  (#787)

* chore: clean up magnitude info usage and type conversions

* refactor: review changes

* fix: order struct params by size

* fix: correct and simplify calc for slashed pending magnitude

* fix: storage gap

* feat: cleanup

* chore: remove some type conversion bs and minor formatting

* chore: clean up free magnitude logic

* chore: rename pending deallocations and fix stack too deep

* feat: slashing magnitudes cleanup (#786)

* refactor: slashing magnitudes cleanup
* refactor: assert `bipToSlash` is bounded
* assert `bipsToSlash` is lte 100% and gt 0%.

* refactor: move `isOperatorSlashable` -> AVSD

* refactor: batch validate opsets on allocations

- adds `AVSD.isOperatorSetBatch(operatorSets)`

* feat: add pausing to ALM

* refactor: remove single use helper

- removes `_getLatestTotalMagnitude(operator, strategy)`

* refactor: rename `ALLOCATION_DELAY_CONFIGURATION_DELAY`

* refactor: remove `Slasher`

* refactor: move constants + immutables to storage contracts

* refactor: custom errors `RewardsCoordinatorStorage`

* chore: dependency cleanup

* fix: remove unused internal getter

* chore: batch validate operator sets and minor cleanup

* fix: fix stack too deep and compiler errors

---------

Co-authored-by: wadealexc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants