Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIVE-7357] Feature - Decrease EIP-1559 base fee multiplier #7991

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

lambertkevin
Copy link
Contributor

@lambertkevin lambertkevin commented Oct 3, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Transactions using EIP-1559 will now only be sure to have enough base fee to be included in the next 3 blocks instead of the next 4 blocks before

📝 Description

Ledger Live is using a base fee multiplier to make sure the transactions crafted can be included in X blocks in the future based on the EIP-1559 spec.

Example of the fee system from Blocknative:

Block Base Fee % Full Increase in Base Fee Priority Fee specified Max Fee specified Gas Price Paid if confirmed
1 100.0 GWEI 100% 12.5% 2.0 202.0 102.0
2 112.5 GWEI 100% 12.5% 2.0 202.0 114.5
3 126.6 GWEI 100% 12.5% 2.0 202.0 128.6
4 142.4 GWEI 100% 12.5% 2.0 202.0 144.4
5 160.2 GWEI 100% 12.5% 2.0 202.0 162.2
6 180.2 GWEI 100% 12.5% 2.0 202.0 182.2
7 202.7 GWEI - - 2.0 202.0 Ineligible

Until now we were having a 50% increase of the base fee which ensured at least 4 blocks even in the worst network conditions, we're decreasing to 27% ensuring 3 blocks now.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

It should allow to create transactions capable of being included
in the next 3 blocks minimum
@lambertkevin lambertkevin requested a review from a team as a code owner October 3, 2024 11:41
Copy link

vercel bot commented Oct 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Oct 3, 2024 11:41am
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 3, 2024 11:41am
native-ui-storybook ⬜️ Ignored (Inspect) Oct 3, 2024 11:41am
react-ui-storybook ⬜️ Ignored (Inspect) Oct 3, 2024 11:41am
web-tools ⬜️ Ignored (Inspect) Oct 3, 2024 11:41am

@lambertkevin lambertkevin merged commit ced792c into develop Oct 4, 2024
52 of 55 checks passed
@lambertkevin lambertkevin deleted the feature/decrease-EIP1559-base-fee-multiplier branch October 4, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants