Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flaky test e2e desktop #7999

Merged
merged 1 commit into from
Oct 3, 2024
Merged

fix: flaky test e2e desktop #7999

merged 1 commit into from
Oct 3, 2024

Conversation

KVNLS
Copy link
Member

@KVNLS KVNLS commented Oct 3, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bugfixes, you can explain the previous behavior and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@KVNLS KVNLS self-assigned this Oct 3, 2024
Copy link

vercel bot commented Oct 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2024 2:35pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2024 2:35pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2024 2:35pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2024 2:35pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2024 2:35pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD screenshots Screenshots have been updated labels Oct 3, 2024
@live-github-bot live-github-bot bot removed the screenshots Screenshots have been updated label Oct 3, 2024
@KVNLS KVNLS marked this pull request as ready for review October 3, 2024 14:57
@KVNLS KVNLS requested review from a team as code owners October 3, 2024 14:57
@KVNLS KVNLS merged commit 2f366a9 into develop Oct 3, 2024
41 checks passed
@KVNLS KVNLS deleted the fix/flaky-e2e-tests branch October 3, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants